[Bug 712754] v4l2: add support for multi-planar V4L2 API

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 25 06:17:45 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=712754
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260416|none                        |reviewed
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-25 14:17:41 UTC ---
Review of attachment 260416:
 --> (https://bugzilla.gnome.org/review?bug=712754&attachment=260416)

Basically ok, just related to a comment in the other patch

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1191,3 @@
+            for (i = 0; i < meta->n_planes; i++)
+              total_length += meta->length[i];
+            gst_buffer_resize (buffer, 0, total_length);

Same comment as in the other patch

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list