[Bug 712385] netclock: added new round-trip limit property

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 25 21:23:14 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=712385
  GStreamer | gstreamer (core) | git

--- Comment #3 from Jan Schmidt <thaytan at noraisin.net> 2013-11-26 05:23:10 UTC ---
Review of attachment 262796:
 --> (https://bugzilla.gnome.org/review?bug=712385&attachment=262796)

Please rename the parameter to round-trip-limit, and fix the commit comment. It
should have a summary line like

netclock: Add round-trip-limit parameter

Sometimes, packets might take a very long time to return.
Such packets usually are way too late and destabilize the regression with
their obsolete data. On Wi-Fi, round-trips of over 7 seconds have been
observed.
If the limit is set to a nonzero value, packets with a round-trip period
larger than the limit are ignored.

I think it would make sense to unify this RTT check and the RTT averaging
immediately after, ie set
rtt = GST_CLOCK_DIFF(clock1, clock2) once and use it, and make it so the
rtt_avg also goes to the outlier_observed label, and to reset the timeout to a
shorter value there as well, to retry the soon

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list