[Bug 712612] v4l2bufferpool: take over the floating reference for the new allocator

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 26 04:27:18 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=712612
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260144|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-26 12:27:13 UTC ---
(From update of attachment 260144)
This looks wrong, we should probably just make all GstAllocators non-floating
in the instance_init function.

And the real bug in the previous code here is that we also ref() the newly
created allocator. Everything should work just fine with your patch but without
the ref_sink() call here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list