[Bug 719373] Add multifilesrc support to GES

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719373
  GStreamer | gst-editing-services | git

--- Comment #1 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2013-11-26 18:22:16 UTC ---
Review of attachment 262889:
 --> (https://bugzilla.gnome.org/review?bug=719373&attachment=262889)

That's awesome !

I only have 2-3 little nitpicks around but it really looks nice.
A general remark would be that some tests would be very welcome :)

Can't wait to be able to use that in pitivi !

::: ges/ges-multi-file-source.c
@@ +1,2 @@
+/* GStreamer Editing Services
+ * Copyright (C) 2009 Edward Hervey <edward.hervey at collabora.co.uk>

Copyright lubosz sarnecki :)

@@ +133,3 @@
+  if (asset != NULL) {
+    stream_info = ges_uri_source_asset_get_stream_info (asset);
+    disc_caps = gst_discoverer_stream_info_get_caps (stream_info);

You need to unref them after usage.

::: ges/ges-uri-asset.c
@@ -470,3 +471,4 @@
       "extractable-type", GES_TYPE_URI_CLIP, NULL);
   discoverer = GES_URI_CLIP_ASSET_GET_CLASS (asset)->sync_discoverer;
-  info = gst_discoverer_discover_uri (discoverer, uri, &lerror);
+
+  if (g_str_has_prefix (uri, "multifile://")) {

It would be extra nice to document that new protocol somewhere :)

@@ -471,2 +472,4 @@
   discoverer = GES_URI_CLIP_ASSET_GET_CLASS (asset)->sync_discoverer;
-  info = gst_discoverer_discover_uri (discoverer, uri, &lerror);
+
+  if (g_str_has_prefix (uri, "multifile://")) {
+    first_file = g_strdup_printf (&uri[12], 1);

I know the name is just above but it might be better to strlen "multifile://"
and have a define somewhere for that string so that we can change it easily,
really a minor nitpick though.

@@ -472,1 +473,4 @@
-  info = gst_discoverer_discover_uri (discoverer, uri, &lerror);
+
+  if (g_str_has_prefix (uri, "multifile://")) {
+    first_file = g_strdup_printf (&uri[12], 1);
+    first_file_uri = gst_filename_to_uri (first_file, &lerror);

Shouldn't you free that ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.