[Bug 719383] New: rtpbasepayload: Perfect timestamps incorrectly computed.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719383
  GStreamer | gst-plugins-base | git

           Summary: rtpbasepayload: Perfect timestamps incorrectly
                    computed.
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: sebras at hotmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In gst_rtp_base_payload_prepare_push() if perfect_rtptime == TRUE and
data.offset and base_offset != GST_BUFFER_OFFSET_NONE perfect timestamps will
be used to compute the rtptime of each buffer based on its offset compared to
the first buffer passed through the payloader.

Now, the expression looks like this:

rtptime = ts_base + base_rtime + data.offset - base_offset;

ts_base is the random rtp offset expressed in media clock hz.
base_rtime is the first buffers running time expressed in hz (it is sampled for
the first buffer in the else clause).
base_offset is the first buffer's data.offset expressed in ns.
data.offset is the current buffer's offset expressed in ns.

This means that the above expression is a mix of hz and ns.

The attached patchs fixes this and does some cosmetic changes to make it less
probable that a similar mistake takes place in the future.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.