[Bug 693772] avdec: decoder frame list getting long

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693772
  GStreamer | gst-libav | git

--- Comment #14 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2013-11-27 22:32:11 UTC ---
(In reply to comment #13)
> Review of attachment 262898 [details]:
> 
> ::: ext/libav/gstavviddec.c
> @@ +545,3 @@
>    if (frame->mapped)
>      gst_video_frame_unmap (&frame->vframe);
> +  gst_video_decoder_release_frame (GST_VIDEO_DECODER (ffmpegdec),
> frame->frame);
> 
> How do you prevent calling both finish_frame() and release_frame() ?

I don't have to.  It is perfectly safe when that happens.  Then release_frame
will only unref the codec frame, which is what happened on that line before
patch.  If it is still in the list (as when _finish_frame not called), then it
will also remove it there.  That is the behaviour which is needed there, as we
need to release the frame "all the way".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.