[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256309|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-02 18:20:05 UTC ---
Review of attachment 256309:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=256309)

Looks generally good to me, but I'd like to have a second opinion on the names
of the function and callback type :)

::: gst/gstutils.c
@@ +3837,3 @@
+    has_a_pad = TRUE;
+
+    if (ret <= GST_FLOW_NOT_NEGOTIATED) {

As mentioned above I think we should handle FLUSHING the same way as
EOS/NOT_LINKED. And between EOS and NOT_LINKED

@@ +3851,3 @@
+
+  if (G_UNLIKELY (!has_a_pad)) {
+    cret = GST_FLOW_OK;

You initialize that above already ;) I think this case must not happen and you
can add an assertion for that

::: gst/gstutils.h
@@ +916,3 @@
+ * Returns: %TRUE when a #GstFlowReturn was set, %FALSE if there are no more
+ *
+ * Since: 1.3

Since: 1.4

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.