[Bug 709312] videoflip: Add an automatic method that flip base on image-orientation tag

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709312
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256319|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-03 09:57:15 UTC ---
Review of attachment 256319:
 --> (https://bugzilla.gnome.org/review?bug=709312&attachment=256319)

::: gst/videofilter/gstvideoflip.c
@@ +1057,3 @@
+        video_flip_methods[method].value_nick);
+
+    videoflip->method = method;

The handling of the properties does not make sense to me. You will now return
non-auto from get_property.

I think you should just store the currently in use method separate from the set
property. So the former can never be auto, but the latter can be auto, and in
that case the former would change on tag events.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.