[Bug 709180] mpegts: Return GstMpegTsDescriptor in mpegts_get_descriptor_from_*

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 7 08:40:24 CEST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=709180
  GStreamer | gst-plugins-bad | git

Jesper Larsen <jesper.larsen> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256178|0                           |1
        is obsolete|                            |

--- Comment #2 from Jesper Larsen <jesper.larsen at ixonos.com> 2013-10-07 06:40:18 UTC ---
Created an attachment (id=256598)
 View: https://bugzilla.gnome.org/attachment.cgi?id=256598
 Review: https://bugzilla.gnome.org/review?bug=709180&attachment=256598

Patch v2

Reworked the patch a bit. Split up into 3 commits.

The first commit introduces new ISO 639 parsing functions in mpegts-lib:
A function to get a specific table id, as mentioned in the previous comment.
A function to get the number of languages in the descriptor.

The second commit does the change in return type for the
mpegts_get_descriptor_from_* functions. This commit uses the descriptors in the
old non-ideal ways in order to by able to compile.

The third commit changes the use of the language descriptor, so that the new
mpegts-lib functions are used.

Seems like a bit of thought is needed regarding the AC3 parsing, as this
descriptor holds quite a lot of information. Maybe we can work on the current
patch set as a step in the right direction?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list