[Bug 698853] HTML5 kind attribute (subtitles, captions, metadata, descriptions, chapters)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698853
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255262|none                        |needs-work
             status|                            |

--- Comment #36 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-07 11:44:09 UTC ---
Review of attachment 255262:
 --> (https://bugzilla.gnome.org/review?bug=698853&attachment=255262)

Please split this into multiple patches. In general looks good I guess, just
needs someone to sit down and properly define and scope this tag :/

::: ext/ogg/gstoggdemux.c
@@ +4761,3 @@
 #endif

+  gst_tag_register_musicbrainz_tags ();

Maybe this should be deprecated and get a better name :) gst_tag_init() :)

::: gst/subparse/Makefile.am
@@ +19,2 @@
 libgstsubparse_la_LDFLAGS = $(GST_PLUGIN_LDFLAGS)
+libgstsubparse_la_LIBADD = $(GST_LIBS) $(GST_BASE_LIBS)
$(GST_PLUGINS_BASE_LIBS) -lgsttag- at GST_API_VERSION@

Why do you link subparse to libgsttag although no changes are in subparse?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.