[Bug 709414] dvbsrc: Uses deprecated field frontend type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709414
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256755|none                        |needs-work
             status|                            |

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> 2013-10-08 19:42:52 UTC ---
Review of attachment 256755:
 --> (https://bugzilla.gnome.org/review?bug=709414&attachment=256755)

::: sys/dvb/gstdvbsrc.c
@@ +115,3 @@
 #define DEFAULT_DVB_BUFFER_SIZE (10*188*1024)   /* Default is the same as the
kernel default */
 #define DEFAULT_BUFFER_SIZE 8192        /* not a property */
+#define DEFAULT_DELSYS 0

Use the actual enum value (SYS_UNDEFINED ?)

@@ +866,3 @@
   adapter_name = g_strdup (fe_info.name);

+  adapter_structure = gst_structure_new ("dvb-adapter",

hmmm... Any way we could make this a "tiny bit" more readable ? :)

Do we really need to have FALSE for the delsys that are not spuported ?

Iterating over the known ones and just adding the values (gst_structure_set...)
would make the resulting structure shorter and the code a bit more readable.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.