[Bug 709747] [wayland_egl] Add support for GstVideoOverlay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709747
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256826|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-09 16:54:33 UTC ---
Review of attachment 256826:
 --> (https://bugzilla.gnome.org/review?bug=709747&attachment=256826)

Does all this still work without setting a window handle/display, and then
creates a new window?

::: configure.ac
@@ +878,3 @@
+  else
+    PKG_CHECK_MODULES(GTK2, gtk+-2.0, HAVE_GTK_20=yes, HAVE_GTK_20=no)
+    if test "x$HAVE_GTK_20" = "xyes"; then

Just remove GTK2 support, nobody needs that :)

::: gst-libs/gst/gl/gstgldisplay.h
@@ +68,2 @@
 GstGLAPI       gst_gl_display_get_gl_api             (GstGLDisplay * display);
+gpointer       gst_gl_display_get_platform_display   (GstGLDisplay * display);

Would this be an EGLDisplay with EGL, a X11 display connection with X11, etc.?
Make it's usage consistent :) I think that would make sense in general, and
then also connected with GstContext usage

::: gst-libs/gst/gl/wayland/wayland_event_source.c
@@ +113,2 @@
   if (source->pfd.revents) {
+    gst_gl_wl_display_roundtrip_queue (source->display, source->queue);

Why not the Wayland function?

::: tests/examples/gtk/gstgtk.c
@@ +62,3 @@
+#elif defined(GDK_WINDOWING_X11) && defined(GDK_WINDOW_XID)
+  gst_video_overlay_set_window_handle (videooverlay,
+      (guintptr) GDK_WINDOW_XID (gtk_widget_get_window (window)));

This code probably also needs some work to be ported to GTK3 for the other
backends. Take a look at gst-plugins-base/tests/examples/overlay. There's a GTK
example.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.