[Bug 709754] gst_audio_ring_buffer_set_channel_positions() clears need_reorder flag wrongly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709754
  GStreamer | gst-plugins-base | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.1

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-09 17:01:33 UTC ---
Will backport to 1.2 later.

commit 6d659e3c6fe978e0400ab21d317504d18642e759
Author: Takashi Iwai <tiwai at suse.de>
Date:   Tue Oct 8 16:02:46 2013 +0200

    audioringbuffer: Don't clear need_reorder flag too early

    gst_audio_ring_buffer_set_channel_positions() checks whether the given
    positions are identical with the current setup and returns
    immediately if so.  But it also clears need_reorder flag before this
    comparison, thus this flag might be wrongly cleared if the function is
    called twice with the same channel positions.

    Move the flag clearance after the check.

    https://bugzilla.gnome.org/show_bug.cgi?id=709754

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.