[Bug 709795] curlsftpsink - new libcurl-based sink element for SFTP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709795
  GStreamer | gst-plugins-bad | git

--- Comment #2 from Sorin L. <sorin.l at mail.com> 2013-10-11 13:43:35 UTC ---
Review of attachment 256880:
 --> (https://bugzilla.gnome.org/review?bug=709795&attachment=256880)

I will upload a new patch updated according to your remarks. Hope I didn't
missed anything.
Thanks for the quick feedback, btw.

::: ext/curl/gstcurlsftpsink.c
@@ +31,3 @@
+ * gst-launch filesrc location=/home/jdoe/some.file ! curlsftpsink  \
+ *     file-name=some.file.backup  \
+ *     user=john location=sftp://192.168.0.1/~/sftp_tests/  \

That was a design decision made earlier (see gstcurlbasesink.c) and, as I
understand it, it gives us more flexibility having it this way.
The file name can change dynamically while the pipeline is PLAYING (for example
it can get a timestamp appended as suffix) while the destination location
remains the same. The effective upload is handled in a separate thread which
gets notified of file name changes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.