[Bug 703518] Qt5/QtQuick 2.0 video element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703518
  GStreamer | qt-gstreamer | unspecified

--- Comment #23 from Benjamin Federau <benjamin.federau at basyskom.com> 2013-10-11 16:14:29 UTC ---
(In reply to comment #18)
> Review of attachment 248292 [details]:
> 
> ::: qt-gstreamer-orig/examples/CMakeLists.txt
> @@ +36,3 @@
> +
> +    if (USE_QT5)
> +        add_subdirectory(qmlplayer2)
> 
> This should be under if (Qt4or5_Quick2_FOUND) or something like that...
> 
> ::: qt-gstreamer-orig/examples/qmlplayer/qmlplayer.qml
> @@ -17,3 +17,3 @@
>  */
>  import QtQuick 1.0
> -import QtGStreamer 0.10
> +import QtGStreamer.QtQuick1 0.10
> 
> This is definitely wrong. It used to work with import QtGStreamer and it should
> still work the same way. We don't want to break existing applications.

I fully agree with you!

> 
> ::: qt-gstreamer-orig/examples/qmlplayer2/main.cpp
> @@ +23,3 @@
> +
> +#ifndef QMLPLAYER_NO_OPENGL
> +# include <QtOpenGL/QGLWidget>
> 
> No QGLWidget needed anymore
> 
> ::: qt-gstreamer-orig/examples/qmlplayer2/qmlplayer2.pro
> @@ +21,3 @@
> +
> +# link against QtDeclarative and QtOpenGL
> +QT += declarative opengl
> 
> opengl not needed anymore

Yes remove it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.