[Bug 709970] New feature for review: Base class for source components and OMX camera component

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709970
  GStreamer | gst-omx | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-10-13 15:57:36 UTC ---
Thanks a lot for your contribution!

Am I looking at the wrong branch or is there noting GstOMXBaseSrc ? 
Am I right to assume you did the testing on a RPi? Any other device ?

I haven't read the src bits of the OMX spec, but I assume your code works.

Can you have a look at bug #678402 and check if that API works for OMX camera
devices? 

As for the code itself:
Don't do gst_omx_camera_src_format_caps, use gst_caps_new_simple()
Why the stop()->close()->close_unlocked() chain of calls, could all be the same
function?
Same comment for enable/disable/start/stop_capturing functions and their
_unlocked variants.
Don't use g_new() for the GstVideoInfo, put it on the stack or in the object
structure.
Don't implement get_times(), it's only for fake sources, OMX is real sources
In the change_state function, the start part should happen before chaining up.
I'm not a big fan of the color enhancement as a string, does it make sense to
make it into two separate integer properties instead?

Do you know if its possible to change any of the properties at runtime?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.