[Bug 710088] rtsp-server: Socket not unreffed after calling gst_rtsp_connection_create_from_socket()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710088
  GStreamer | gst-rtsp-server | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257240|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-14 17:43:19 UTC ---
Review of attachment 257240:
 --> (https://bugzilla.gnome.org/review?bug=710088&attachment=257240)

This looks wrong. While gst_rtsp_connection_create_from_socket() does take
ownership of the socket, it doesn't advertise this via gobject-introspection
annotations and also does only take ownership of the socket if everything
succeeds. This is not binding friendly behaviour.

So what should happen here is that gst_rtsp_connection_create_from_socket()
should be fixed. And depending on how it's fixed (IMHO it shouldn't take
ownership of the socket because that would now break backwards compat), this
fix here needs to be adapted (and if it takes ownership of the socket still,
this should be added as gobject-introspection annotation).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.