[Bug 691617] avenc_aac: errors out with "encoder not initialized"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691617
  GStreamer | gst-libav | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257060|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-14 19:27:12 UTC ---
Review of attachment 257060:
 --> (https://bugzilla.gnome.org/review?bug=691617&attachment=257060)

::: ext/libav/gstavaudenc.c
@@ +80,3 @@
+#define GST_TYPE_FFMPEGAUDENC_COMPLIANCE (gst_ffmpegaudenc_compliance_get_type
())
+static GType
+gst_ffmpegaudenc_compliance_get_type (void)

You could put this type into gstavcodecmap.c or something to share it

::: ext/libav/gstavaudenc.h
@@ +59,3 @@
+  GST_FFMPEGAUDENC_NORMAL = 0,
+  GST_FFMPEGAUDENC_UNOFFICIAL = -1,
+  GST_FFMPEGAUDENC_EXPERIMENTAL = -2

Use FF_COMPLIANCE_VERY_STRICT and the others instead of duplicating the values

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.