[Bug 709970] New feature for review: Base class for source components and OMX camera component

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709970
  GStreamer | gst-omx | git

Tuomas Jormola <tj> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|Mac OS                      |Linux

--- Comment #5 from Tuomas Jormola <tj at solitudo.net> 2013-10-19 10:58:30 UTC ---
Committed some updates. Highlight being H.264 now supported in RPi.

> 1. Feature: On RPi, it should be possible to tunnel the camera via the encoder
> component and get e.g. H.264 or MJPEG encoded video passed to downstream in the
> pipeline, if such caps was requested.

and

> 2. Feature: Probe the camera output port for supported uncompressed video
> output formats

and

> As for the code itself:
> Don't do gst_omx_camera_src_format_caps, use gst_caps_new_simple()

https://github.com/tjormola/gst-omx/commit/8dea32751058a78431d998b6cf772f9c20380c0e

> 3. Feature: On RPi, we also need to activate camera preview output port
https://github.com/tjormola/gst-omx/commit/5e347c6f00b02b28d3e17ffee51100c0a5bc46da

> Why the stop()->close()->close_unlocked() chain of calls, could all be the same
> function?
> Same comment for enable/disable/start/stop_capturing functions and their
> _unlocked variants.
https://github.com/tjormola/gst-omx/commit/a43064e63a7c89a3fbe1bbde7da63e5fd17be2d0

> Don't implement get_times(), it's only for fake sources, OMX is real sources
https://github.com/tjormola/gst-omx/commit/8ae3bd7bb9b9cfd53b105e47e4720c7088356ca8

> In the change_state function, the start part should happen before chaining up.
https://github.com/tjormola/gst-omx/commit/454daa88e4df374dd79ce3ccfe0253c2f9ac635f

> I'm not a big fan of the color enhancement as a string, does it make sense to
> make it into two separate integer properties instead?
https://github.com/tjormola/gst-omx/commit/2d8002ad52d329de86527e446bb74771e4526010

Still TODO:
- Config callback stuff
- Use config callback when opening the device
- Test with Bellagio camera component
- Re-work setting properties and applying of camera configuration so that
properties can be changed when live
- Write a GTK3 test tool
- Is it possible to implement zero copy for non-fragmented frames?
- Investigate the deadlock issue
- Cleanups and little fixes (assertions etc.)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.