[Bug 678011] typefinding: some mpeg files are not identified as mpeg files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678011
  GStreamer | gst-plugins-base | 0.10.36

Pavel Bludov <pbludov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pbludov at altergeo.ru

--- Comment #13 from Pavel Bludov <pbludov at altergeo.ru> 2013-10-28 07:17:19 UTC ---
The detection of mpegps was broken in this commit:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/gst/typefind?h=BRANCH-RELEASE-0_10_19&id=1e2c32779299d99d8cff724614fc841acdb5b86b

Instead of
- len = MPEG2_MAX_PROBE_LENGTH * 2;
- do {
- len = len / 2;
- data = gst_type_find_peek (tf, 0, 5 + len);
- } while (data == NULL && len >= 32);
we have
+ len = MPEG2_MAX_PROBE_LENGTH;
+ do {
+ len = len / 2;
+ data = gst_type_find_peek (tf, 0, 5 + len);
+ } while (data == NULL && len >= 32);

To fix, simply revert

len = MPEG2_MAX_PROBE_LENGTH;

to original

 len = MPEG2_MAX_PROBE_LENGTH * 2;

or reduce MPEG2_MIN_SYS_HEADERS twice.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.