[Bug 671136] mpegtsmux: add support for SDT and NIT tables for DVB-S/DVB-T

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=671136
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Jesper Larsen <jesper.larsen at ixonos.com> 2013-10-28 10:27:31 UTC ---
(In reply to comment #7)
> Review of attachment 257626 [details]:
> 
> @@ +731,3 @@
> +  *data++ = 0xC1;
> +
> +  /* section_number                   - 8  bit uimsbf */
> 
> How will we handle multiple sections ?

Excellent question. This seems to be something that should be handled outside
the library?

With the addition of the section_packetizer I guess there is the possibility of
making the user responsible of updating the public
section_number/last_section_number fields in the GstMpegTsSection?

> 
> @@ +795,3 @@
> +
> +  /* We have a parsed GstMpegTsNIT */
> +  section->cached_parsed = (gpointer) _gst_mpegts_nit_copy (nit);
> 
> Shouldn't we just transfer ownership to the section ? Do we plan of re-using a
> NIT accross multiple sections ?
> 

Good point. Lets make the transfer full.

> 
> ::: gst-libs/gst/mpegts/gstmpegtssection.c
> @@ +795,3 @@
> +
> +/**
> + * gst_mpegts_section_packetize:
> 
> _private_section_packetize ?

This function needs to be public for use in i.e. muxer?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.