[Bug 707534] BufferPool don't buffer GstMemory in 1.x
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Oct 29 09:34:17 CET 2013
https://bugzilla.gnome.org/show_bug.cgi?id=707534
GStreamer | gstreamer (core) | git
--- Comment #5 from Michael Olbrich <m.olbrich at pengutronix.de> 2013-10-29 08:34:09 UTC ---
Handling more stuff in the allocator is a good Idea, I think. Though I'm
not sure how we can handle this in a clean way in the v4l2 plugin. The
GstV4l2BufferPool currently mixes buffer pool, memory allocation and v4l2
queue handling in on class. Separating the allocation parts might be
tricky. Also, We'll probably have 2 possible allocators: dmabuf and mmap.
Relying on the user to pick one isn't nice, but we cannot know if dmabuf is
supported until we try to allocate a buffer. So the buffer pool must be
able to switch allocators while allocating the first buffer...
About the gst_allocator_wait_for_empty(): Right now
gst_v4l2_buffer_pool_stop() and therefore
gst_v4l2_buffer_pool_free_buffers() isn't called until all buffers are back
in the pool. It's actually called when the last buffer returns if
necessary. I think we should handle memories the same way. I think there
may be dead locks with a blocking API.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list