[Bug 709174] Add avfvideosrc to the OS X build in applemedia
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Oct 30 13:43:59 CET 2013
https://bugzilla.gnome.org/show_bug.cgi?id=709174
GStreamer | gst-plugins-bad | git
--- Comment #17 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-10-30 12:43:53 UTC ---
(In reply to comment #10)
> Review of attachment 258550 [details]:
>
> ::: sys/applemedia/avfvideosrc.m
> @@ +74,2 @@
> );
>
>
> I think these changes should go in a different commit, they are not related to
> using AVFoundation :)
>
> And for this last part I would do something like:
> VIDEO_CAPS_BGRA (1280, 720))
> #ifdef HAVE_IOS
> ";" VIDEO_CAPS_BGRA (1920, 1280))
> #endif
>
> I think it's easier to read and easier to know which resolutions are being
> added
Updated locally + patch splitted into:
avfvideosrc: only enable 1920x1080 preset on iOS
applemedia: enable avfvideosrc if AVFoundation is present
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list