[Bug 699924] smoothstreaming: no audio with BBC bigbuckbunny stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699924
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257428|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-30 21:05:21 UTC ---
Review of attachment 257428:
 --> (https://bugzilla.gnome.org/review?bug=699924&attachment=257428)

::: ext/smoothstreaming/gstmssmanifest.c
@@ +612,3 @@
+
+        if (mapinfo.size >= 16) {
+          gint cbSize = GST_READ_UINT16_LE (mapinfo.data + 16);

You need to check that it's >= 18 if you want to read 2 bytes at offset 16

@@ +613,3 @@
+        if (mapinfo.size >= 16) {
+          gint cbSize = GST_READ_UINT16_LE (mapinfo.data + 16);
+          fprintf (stderr, "%s cbSize: %d\n", __func__, cbSize);

You can use GST_DEBUG() here

@@ +619,3 @@
+             * whole "WaveFormatEx" */
+            gst_buffer_resize (codec_data, 18, -1);
+            goto endif;

Best would be without a goto here :) Also won't you still pass the complete
struct as codec_data in all other cases?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.