[Bug 710342] docs: various constructors are annotated as "transfer full", but return floating references

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710342
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257584|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-30 21:38:16 UTC ---
Review of attachment 257584:
 --> (https://bugzilla.gnome.org/review?bug=710342&attachment=257584)

::: gst/gsttask.c
@@ +391,3 @@
  * @func is called.
  *
+ * Returns: (transfer floating): A new #GstTask.

This shouldn't be floating IMHO, so we should unset the flag. Floating only
makes sense if the object becomes the child of some other object

::: gst/gsttaskpool.c
@@ +159,3 @@
  * GThreadPool for threads.
  *
+ * Returns: (transfer floating): a new #GstTaskPool. gst_object_unref() after
usage.

Same here

::: libs/gst/base/gstcollectpads.c
@@ +291,3 @@
  * MT safe.
  *
+ * Returns: (transfer floating): a new #GstCollectPads, or NULL in case of an
error.

and here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.