[Bug 710810] [geometrictransform] add a matrix plugin for a 2D perspective transform

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710810
  GStreamer | gst-plugins-bad | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258024|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-31 21:24:35 UTC ---
Review of attachment 258024:
 --> (https://bugzilla.gnome.org/review?bug=710810&attachment=258024)

Looks good in general, but the name seems wrong

::: gst/geometrictransform/gstmatrix.c
@@ +187,3 @@
+  /* Perspective division */
+  xi = xp / w;
+  yi = yp / w;

As this is not a normal matrix multiplication but perspective transformation,
maybe the element should be called perspectivetransform instead?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.