[Bug 699924] smoothstreaming: no audio with BBC bigbuckbunny stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699924
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258677|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-31 21:56:52 UTC ---
Review of attachment 258677:
 --> (https://bugzilla.gnome.org/review?bug=699924&attachment=258677)

Generally looks good

::: ext/smoothstreaming/gstmssmanifest.c
@@ +588,3 @@
   gchar *codec_data_str =
       (gchar *) xmlGetProp (node, (xmlChar *) "CodecPrivateData");
   GstBuffer *codec_data = NULL;

Isn't this causing the < 18 byte codec_data to be used still? Shouldn't it
instead really ignore it and not do anything with it?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.