[Bug 710984] misc patch to improve MSVC compatibility and CMake build script

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Oct 31 23:05:04 CET 2013


https://bugzilla.gnome.org/show_bug.cgi?id=710984
  GStreamer | gst-plugins-gl | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258264|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-31 22:04:59 UTC ---
Review of attachment 258264:
 --> (https://bugzilla.gnome.org/review?bug=710984&attachment=258264)

::: gst-libs/gst/gl/gstglapi.h
@@ +47,3 @@
 #  include <GL/gl.h>
 #  include <GL/glu.h>
+# if defined(__WIN32__) || defined(_WIN32)

Just use #if defined(G_OS_WIN32) here

::: gst/gl/gstglmosaic.c
@@ +263,2 @@
+    /* *INDENT-OFF* */
+    GLfloat temp[]=

Just move GLFloat *v_vertices here and initialize it with {} directly instead
of introducing a new variable

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list