[Bug 695090] rganalysis: fix tests

Mon Sep 2 15:05:55 PDT 2013

https://bugzilla.gnome.org/show_bug.cgi?id=695090
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.5

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-09-02 22:05:49 UTC ---
Thanks for the patch! Your analysis seems correct, and the patch looks fine
too, I've pushed it now. Sorry it took so long:

commit 966f848edb70a6d6b7d172b842a8ceb600e4d747
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Mon Sep 2 23:00:29 2013 +0100

    replaygain: fix taglist leak in rganalysis

    And add some FIXMEs.

commit cc4f985332d65fff9af165006b661e887a434172
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Mon Sep 2 22:50:58 2013 +0100

    tests: rganalysis: rename function for clarity

commit 92dde0760ba17f4df4a0a68a552f953161c83569
Author: Christoph Reiter <reiter.christoph at gmail.com>
Date:   Mon Mar 18 14:32:07 2013 +0100

    tests: fix skipped rganalysis tests

    In 0.10 elements would post tag messages on the bus
    directly, and rganalysis would only post a tag message
    when it changed tags. In 1.0, only sinks post tag
    messages when they receive the serialised tag event.
    This means that we get an additional tag message on
    the bus now where we didn't expect one before.

    https://bugzilla.gnome.org/show_bug.cgi?id=695090

Having said that, the tag handling in rganalysis is very dodgy and broken in
some respects, but that's independent from this patch and the tests.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.