[Bug 706340] videofilter: it might make sense to implement the "transform_meta" virtual method

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Sep 4 02:10:20 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706340
  GStreamer | gst-plugins-base | git

--- Comment #19 from Wim Taymans <wim.taymans at gmail.com> 2013-09-04 09:10:16 UTC ---
It's still a bit inconstistent in the naming. I would suggest:

GST_META_TAG_<subsys>[_<feature>]_STR

thus:

GST_META_TAG_MEMORY_STR  "memory"

GST_META_TAG_AUDIO_STR
GST_META_TAG_AUDIO_CHANNELS_STR

GST_META_TAG_VIDEO_STR
GST_META_TAG_VIDEO_ORIENTATION_STR
GST_META_TAG_VIDEO_SIZE_STR
GST_META_TAG_VIDEO_COLORSPACE_STR

With optionally, defines that return the GQuark (either using a static
variable, g_quark_from_string() or a method to do the GOnce registration of the
quark):

GST_META_TAG_MEMORY         (_gst_meta_tag_memory)
GST_META_TAG_AUDIO          (g_quark_from_string(GST_META_TAG_AUDIO_STR))
GST_META_TAG_AUDIO_CHANNELS (gst_audio_channels_get_meta_tag())

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list