[Bug 707433] xvid: Port plugin to 1.0.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707433
  GStreamer | gst-plugins-bad | 1.0.7

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254028|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-04 09:17:55 UTC ---
Review of attachment 254028:
 --> (https://bugzilla.gnome.org/review?bug=707433&attachment=254028)

::: ext/xvid/gstxviddec.c
@@ +53,3 @@
             0x0000ff00) "; " RGB_24_32_STATIC_CAPS (32, 0x0000ff00,
0x00ff0000,
             0xff000000) "; " RGB_24_32_STATIC_CAPS (32, 0x000000ff,
0x0000ff00,
             0x00ff0000) "; " RGB_24_32_STATIC_CAPS (24, 0x0000ff, 0x00ff00,

These caps are now RGB, xRGB, ARGB, BGRx, etc. We don't use masks in the caps
any longer

@@ +133,3 @@
   dec->sinkpad = gst_pad_new_from_static_template (&sink_template, "sink");
   gst_pad_set_chain_function (dec->sinkpad,
+      (GstPadChainFunction) gst_xviddec_chain);

The signature of the function has changed to contain the parent too, also this
element should just be ported to the GstVideoDecoder base class

@@ +136,2 @@
   gst_pad_set_event_function (dec->sinkpad,
+      (GstPadEventFunction) gst_xviddec_handle_sink_event);

Same

@@ +212,2 @@
     default:
+      ret = gst_pad_push_event (dec->srcpad, event);

gst_pad_event_default()

::: ext/xvid/gstxvidenc.c
@@ +45,3 @@
             0x0000ff00) "; " RGB_24_32_STATIC_CAPS (32, 0x0000ff00,
0x00ff0000,
             0xff000000) "; " RGB_24_32_STATIC_CAPS (32, 0x000000ff,
0x0000ff00,
             0x00ff0000) "; " RGB_24_32_STATIC_CAPS (24, 0x0000ff, 0x00ff00,

All comments from the decoder apply to the encoder too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.