[Bug 707658] New: AS_SCRUB_INCLUDE only works with gcc's cpp

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707658
  GStreamer | gst-plugins-ugly | 0.10.19

           Summary: AS_SCRUB_INCLUDE only works with gcc's cpp
    Classification: Platform
           Product: GStreamer
           Version: 0.10.19
        OS/Version: opensolaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=254306)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=254306)
fix as-scrub-include so that it works for the non-gcc case

Building gst-plugins-ugly 0.10.19 on x86_64-pc-solaris2.11 (OpenIndiana
oi151a8) with the Oracle Studio 12.3 compiler toolchain.

When running configure, it outputs:

checking for GLIB... yes
"s#-I[No ##
": 1: unbalanced brackets ([])
checking for ORC... no

I eventually tracked that down to the AS_SCRUB_INCLUDE, which is attempting to
execute

  INCLUDE_DIRS=`echo | cpp -v 2>&1`

      INCLUDE_DIRS=`echo $INCLUDE_DIRS | sed -e 's/.*<...> search starts
here://' | sed -e 's/End of search list.*//'`
  for dir in $INCLUDE_DIRS; do
        GIVEN_CFLAGS=`echo $GIVEN_CFLAGS | sed -e "s#-I$dir ##"`
  done


That's not portable for a couple reasons -- it expects cpp to exist, be in the
person running configure's PATH, and to have GNU cpp syntax.

Some platforms don't even have a separate cpp anymore, they just use "cc -E",
which configure correctly detects.

What should probably happen is something like

if test X"$GCC" = X"yes" ; then
  INCLUDE_DIRS=`echo | cpp -v 2>&1`
else
  dnl a suitable default, so that $INCLUDE_DIRS isn't empty later
  INCLUDE_DIRS=/usr/include
fi

Alternately, the entire check could just be skipped if not using gcc, as it
appears to be coded just to work around an issue with some versions of gcc.

One possible patch is attached.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.