[Bug 692953] alsasink does not work at all with default value "sync=true"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692953
  GStreamer | gst-plugins-base | 1.0.9

--- Comment #148 from Thomas DEBESSE <thomas.debesse at rcf.fr> 2013-09-11 18:00:55 UTC ---
Effectively, without this modification, 

the "err" variable in this code:

> if (err < 0) {
>  GST_DEBUG_OBJECT (asink, "Write error: %s", snd_strerror (err));

is not this err:

> err = snd_pcm_writei (alsa->handle, ptr, cptr);

but this err:

> err = snd_pcm_wait (alsa->handle, (4 * alsa->period_time / 1000));

which does not make sense. Your modification seems more logical.

And the other modification (xrun recovery; goto write_error) is a good idea, as
long as we are certain that the only one thing which may be returned in case of
error is -EPIPE (someone to confirm ?)

I'll try this code tomorrow. :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.