[Bug 706083] v4l2src: UVC Allocated buffers wrapped in GstBuffer get orphaned by GstBuffer API

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 19 12:50:11 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706083
  GStreamer | gst-plugins-good | git

--- Comment #22 from Robert Krakora <rob.krakora at messagenetsystems.com> 2013-09-19 19:50:09 UTC ---
Review of attachment 255308:
 --> (https://bugzilla.gnome.org/review?bug=706083&attachment=255308)

::: sys/v4l2/gstv4l2bufferpool.h
@@ +34,2 @@
 #include "gstv4l2object.h"
+#include <gst/glib-compat-private.h>

Maybe not, but the code would not build without it.  Please suggest an
alternative.

@@ +67,2 @@
   GstBuffer **buffers;
+  GMutex lock;

GST_OBJECT_LOCK/UNLOCK is kind of a big mutex for this job.  I took this from
the 0.10 v4l2src buffer pool source.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list