[Bug 708416] Implement flushing seek support in collectpads

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 19 14:58:12 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=708416
  GStreamer | gstreamer (core) | git

--- Comment #5 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-09-19 21:58:07 UTC ---
Review of attachment 255352:
 --> (https://bugzilla.gnome.org/review?bug=708416&attachment=255352)

There is a wrong update of common/ in there.

::: libs/gst/base/gstcollectpads.c
@@ +1199,3 @@
   if (!GST_COLLECT_PADS_STATE_IS_SET (data, GST_COLLECT_PADS_STATE_LOCKED) &&
       (GST_COLLECT_PADS_STATE_IS_SET (data, GST_COLLECT_PADS_STATE_WAITING) !=
+          !!waiting)) {

Did you run it through gst-indent? It does produce this horror

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list