[Bug 708532] tsdemux: skips too much when scanning for last PCR

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708532
  GStreamer | gst-plugins-bad | git

--- Comment #1 from Matej Knopp <matej.knopp at gmail.com> 2013-09-21 13:44:23 UTC ---
I'm also not sure about this:
    if (mpegts_packetizer_has_packets (base->packetizer)) {
      while (1) {
        /* Eat up all packets */
        pret = mpegts_packetizer_process_next_packet (base->packetizer);
        if (pret == PACKET_NEED_MORE)
          break;
        if (pret != PACKET_BAD &&
            mpegts_packetizer_get_seen_pcr (base->packetizer) >
            initial_pcr_seen) {
          GST_DEBUG ("Got last PCR");
          done = TRUE;
>>        break;
        }
      }
    }

Why is the break there? This will find the first PCR in the block, but that is
not necessarily the last PCR in file.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.