[Bug 708633] Adder should not take channel mask in consideration when in mono or stereo.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708633
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255577|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-23 15:09:07 UTC ---
Review of attachment 255577:
 --> (https://bugzilla.gnome.org/review?bug=708633&attachment=255577)

::: gst/adder/gstadder.c
@@ +293,3 @@
+
+    s = gst_caps_get_structure (result, i);
+    if (gst_structure_get_int (s, "channels", &channels))

This could be a range or list, not necessarily an int

@@ +348,3 @@
+
+  n = gst_caps_get_size (caps);
+  for (i = 0; i < n; i++) {

In setcaps the size should always be 1, no?

@@ +352,3 @@
+
+    s = gst_caps_get_structure (caps, i);
+    if (gst_structure_get_int (s, "channels", &channels))

And here it should be always an int

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.