[Bug 708636] Collectpads should set *all* its pads to flushing when set_flushing is called, not only the ones in the public list.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708636
  GStreamer | gstreamer (core) | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255583|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-09-23 20:21:59 UTC ---
Review of attachment 255583:
 --> (https://bugzilla.gnome.org/review?bug=708636&attachment=255583)

>From gst_collect_pads_set_flushing(), gst_collect_pads_set_flushing_unlocked()
is called without holding the pads GstObject lock, which is documented to
protect pad_list. I think the solution is to just take the object lock in
gst_collect_pads_set_flushing() ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.