[Bug 708636] collectpads: Should set *all* its pads to flushing when set_flushing is called, not only the ones in the public list

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Sep 24 01:39:58 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=708636
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |slomo at circular-chaos.org
            Summary|Collectpads should set      |collectpads: Should set
                   |*all* its pads to flushing  |*all* its pads to flushing
                   |when set_flushing is        |when set_flushing is
                   |called, not only the ones   |called, not only the ones
                   |in the public list.         |in the public list
     Ever Confirmed|0                           |1

--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-24 08:39:53 UTC ---
You need to take the GstObject lock there. It is already taken from every
caller of set_flushing_unlocked() except for gst_collect_pads_set_flushing().
Taking the object lock there should be fine. I'll update the patch and push.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list