[Bug 708689] New: rtspconnection: RTSP watch is dispatched after closing the connection

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708689
  GStreamer | gst-plugins-base | git

           Summary: rtspconnection: RTSP watch is dispatched after closing
                    the connection
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: ognyan.tonchev at axis.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=255642)
 View: https://bugzilla.gnome.org/attachment.cgi?id=255642
 Review: https://bugzilla.gnome.org/review?bug=708689&attachment=255642

Unset input/output_stream after unreffing the GIOStream

If one creates an RTSP watch for a connection and then calls
rtsp_connection_close() the watch can still be dispatched.
The problem is that rtsp_connection_close() unreffs the giostream but
watch->readsrc won't be unreffed until the last ref to the RTSP watch is
dropped.

I am proposing a small patch which unsets input_stream and output_stream in
gst_rtsp_connection_close() after dropping the reference to the object owning
them - the GIOStream. This way the dispatch function will also notice that the
connection has been closed and will not call message_received()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.