[Bug 706441] adder: Rework/review the way we handle flushing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706441
  GStreamer | gst-plugins-base | 1.x

--- Comment #12 from Thibault Saunier <thibault.saunier at collabora.com> 2013-09-27 09:18:48 UTC ---
(In reply to comment #11)
> Review of attachment 255147 [details]:
> 
> ::: tests/check/elements/adder.c
> @@ +1235,3 @@
>    adder_src = gst_element_get_static_pad (adder, "src");
>    fail_if (GST_PAD_IS_FLUSHING (adder_src));
> +  gst_pad_send_event (adder_src, gst_event_new_flush_start ());
> 
> you're changing the nature of this test with this.

I actually changed the behaviour of Adder concerning flush event comming from
upstream, as now, I do not foward dowstream them unless they are coming from
the result of a flushing seek. That test doesn't make sense anymore in that new
context.

> Shouldn't you add a different unit test ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.