[Bug 675132] tsdemux: implement proper seeking with binary search and keyframe detection
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Apr 1 19:35:48 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=675132
GStreamer | gst-plugins-bad | git
Mathieu Duponchelle <mathieu.duponchelle> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #272581|0 |1
is obsolete| |
--- Comment #28 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-04-02 02:35:44 UTC ---
Created an attachment (id=273444)
View: https://bugzilla.gnome.org/attachment.cgi?id=273444
Review: https://bugzilla.gnome.org/review?bug=675132&attachment=273444
Fixes Edward's observations, will be fixed up.
I fixed Edward's observations. Regarding the h264infos they don't get reused.
I also fixed a remaining problem with my algorithm, which queued packets that
it shouldn't have queued as the rewind was still happening, in certain cases it
was leading to a buffer getting discarded.
It returns GST_FLOW_CUSTOM_ERROR for now in push_pending_data, Edward do you
think I should actually define a custom error value for that? Not too sure if
it is needed.
To test the patch, validate is a good option, I use such command lines :
gst-validate-1.0 filesrc location= /home/meh/Downloads/GH1_00094_1920x1280.MTS
! tsdemux ! h264parse ! avdec_h264 ! xvimagesink --set-scenario
scrub_forward_seeking to assert that the behaviour is correct.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list