[Bug 679768] mpegaudioparse, baseparse: fix tag handling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=679768
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263181|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-02 21:30:50 UTC ---
Review of attachment 263181:
 --> (https://bugzilla.gnome.org/review?bug=679768&attachment=263181)

::: libs/gst/base/gstbaseparse.c
@@ +2259,3 @@

+  /* Push pending events, including SEGMENT events */
+  gst_base_parse_push_events (parse);

Why do you move this code?

@@ +4375,3 @@
   /* We only care about stream tags here */
   if (gst_tag_list_get_scope (taglist) != GST_TAG_SCOPE_STREAM)
+    return FALSE;

Do we? Shouldn't global scope tags just be forwarded?

@@ +4531,3 @@
+ * MT safe.
+ *
+ * Since 1.4

"Since: 1.4" with a colon

@@ +4544,3 @@
+  GST_OBJECT_LOCK (parse);
+  if (tags)
+    GST_DEBUG_OBJECT (parse, "merging tags %" GST_PTR_FORMAT, tags);

What's the point of allowing tags==NULL here?

::: win32/common/libgstbase.def
@@ +28,3 @@
     gst_base_parse_frame_new
     gst_base_parse_get_type
+    gst_base_parse_merge_tags

Also need to add that to the documentation

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.