[Bug 727409] streamsynchronizer does invalid memory access

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727409
  GStreamer | gst-plugins-base | 1.2.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW
                 CC|                            |slomo at coaxion.net
     Ever Confirmed|0                           |1

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-03 18:52:55 UTC ---
That's perfectly legal, yes. Memory can be un-copyable, unmappable, unwritable,
etc. Just having such a memory will limit the usefulness of it a lot.

streamsynchronizer should just error out here if that happens.


OTOH it's entirely not clear to me why we drop DISCONT flags on the first
buffer here. My commit 4 years ago does not really explain it and I can only
remember something about gapless audio playback, where the audio sinks will
cause a short click sound if they see a DISCONT on the first buffer of a new
stream. Should be investigated if this code is still necessary or if it can be
solved in a better way.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.