[Bug 710324] encodebin: Implement subtitles support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710324
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257460|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-04 09:20:52 UTC ---
Review of attachment 257460:
 --> (https://bugzilla.gnome.org/review?bug=710324&attachment=257460)

Looks good in general, a test would be good to have and minor nitpick:

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +668,3 @@
+
+  guint pass;
+  gboolean variableframerate;

Why pass and variableframerate for subtitles? They are always VFR and I'm not
aware of a single multipass encoder for subtitles ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.