[Bug 727560] mpegts: add frequency list, scrambling and dvb ca indentifier descriptor

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727560
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Stefan Ringel <mail at stefanringel.de> 2014-04-04 09:22:32 UTC ---
(In reply to comment #3)
> Review of attachment 273543 [details]:
> 
> ::: gst-libs/gst/mpegts/gst-dvb-descriptor.c
> @@ +1254,3 @@
> +
> +  if (type == 1) {
> +    // satellite
> 
> Don't use C99 comments
o.k.
> 
> @@ +1265,3 @@
> +  len = descriptor->length - 1;
> +
> +  for (guint8 i = 0; i < len; i += 4) {
> 
> If I'm not missing anything this could read over the end of the byte array. It
> should be i < len - 3
o.k.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.