[Bug 723652] missing documentation of GST_PAD_SET_PROXY_CAPS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723652
  GStreamer | documentation | git

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273050|none                        |needs-work
             status|                            |

--- Comment #10 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-04-04 21:59:10 UTC ---
Review of attachment 273050:
 --> (https://bugzilla.gnome.org/review?bug=723652&attachment=273050)

Hi Felipe. Thanks for taking care of this. Just a few nits:

::: gst/gstpad.h
@@ +771,3 @@
+ * @pad: a #GstPad
+ *
+ * Get the @pad #GstPadTemplate. It describe the possible media types

describes

@@ +837,3 @@
+ *
+ * Get the #GstPadEventFunction from the given @pad.
+ * This is the function handle an event for the pad.

This function will handle the pad's events
Or, closer to your version:
This is the function handling events for the pad

@@ +881,3 @@
+ * @pad: a #GstPad
+ *
+ * Return true if the @pad direction is equals to GST_PAD_SRC.

Drop the "is"

@@ +888,3 @@
+ * @pad: a #GstPad
+ *
+ * Return true if the @pad direction is equals to GST_PAD_SINK

Drop the "is"

@@ +952,3 @@
+ *
+ * Check if the @pad should be reconfigured/renegotiated.
+ * The flag has to be unset manually after reconfiguration happened.

manually unset

@@ +966,3 @@
+ * @pad: a #GstPad
+ *
+ * Check if the given @pad is using fixed caps this means that

. This means ..

@@ +981,3 @@
+ * @pad: a #GstPad
+ *
+ * Check if the given @pad is set as proxy caps this meas that the default

as/to
. This
meas/means

@@ +1004,3 @@
+ * @pad: a #GstPad
+ *
+ * Check if the given @pad is set as proxy allocation this means

as/to
. This

@@ +1027,3 @@
+ * @pad: a #GstPad
+ *
+ * Check if the given @pad is proxy scheduling this means that the

proxying maybe, but I'd rather phrase it like the above ones
. This

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.