[Bug 726117] typefinding: issue in MPEG-TS detection logic for streams with Null Pids

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726117
  GStreamer | gst-plugins-base | git

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271535|none                        |needs-work
             status|                            |

--- Comment #4 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-04-04 23:17:33 UTC ---
Review of attachment 271535:
 --> (https://bugzilla.gnome.org/review?bug=726117&attachment=271535)

Thanks for your patch and the sample. I couldn't find any
reference to this field being 00 for valid streams though.
00 seems to be reserved. Can you provide more info on the
rationale behind it? Regarding the patch, just two nits:

::: gst-plugins-base-0.10.34-orig/gst/typefind/gsttypefindfunctions.c
@@ +1938,3 @@
 #define MPEGTS_HDR_SIZE 4
 /* Check for sync byte, error_indicator == 0 and packet has payload */
+/* Adaptation control filed (((data)[3] & 0x30) == 0x00) may be zero for TS
packets with NULL PIDs.

filed/field

@@ +1939,3 @@
 /* Check for sync byte, error_indicator == 0 and packet has payload */
+/* Adaptation control filed (((data)[3] & 0x30) == 0x00) may be zero for TS
packets with NULL PIDs.
+     Still these streams are valid TS streams */

Still,

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.