[Bug 727329] check: souphttpsrc: unknown type name ‘SoupStatus’

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727329
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273675|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-07 07:47:36 UTC ---
Review of attachment 273675:
 --> (https://bugzilla.gnome.org/review?bug=727329&attachment=273675)

::: tests/check/elements/souphttpsrc.c
@@ +42,3 @@
+#define MY_SOUP_STATUS_TYPE SoupKnownStatusCode
+#endif
+#endif

Why so complicated?

SOUP_CHECK_VERSION() should be there since forever so you can just use it, and
just write then

#if SOUP_CHECK_VERSION()
#define ...
#else
#define ...
#endif

Alternatively as this is just a test, what about just storing it as int?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.