[Bug 722760] Add VP8 parser in codecparsers submodule
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Apr 7 21:13:47 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=722760
GStreamer | gst-plugins-bad | 1.x
--- Comment #38 from Gwenole Beauchesne <gb.devel at gmail.com> 2014-04-08 04:13:45 UTC ---
(In reply to comment #37)
> Review of attachment 273522 [details]:
>
> Looks good except for what I wrote in the previous comment
Thanks, I would like to make an ultimate API change in a separate patch maybe.
i.e. make the GstVp8FrameData structure the GstVp8Parser instead and move
gst_vp8_frame_data_init() to gst_vp8_parser_init() + rename
gst_vp8_parse_frame_hdr() to gst_vp8_parser_parse_frame_hdr().
Reason behind this: the parser is best suited to track the entropy coding probs
itself, without assuming that the upper layer would make the additional updates
to GstVp8FrameData when necessary. Besides, I would like GstVp8FrameHdr to
fully represent the parsed state at a point in time, without depending on
another struct. Here, I am thinking about a GstVp8Meta.
WDYT?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list